Review Request 122513: Avoid comparing unintialised variable if BREEZE_HAVE_KSTYLE is not set
David Edmundson
david at davidedmundson.co.uk
Tue Feb 10 16:48:24 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122513/
-----------------------------------------------------------
(Updated Feb. 10, 2015, 4:48 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Hugo Pereira Da Costa.
Repository: breeze
Description
-------
Avoid comparing unintialised variable if BREEZE_HAVE_KSTYLE is not set
if BREEZE_HAVE_KSTYLE is not set CE_CapacityBar remains uninitialised
(random value). It should therefore not be used in any comparisons.
For KDE4, BREEZE_HAVE_KSTYLE will always be false regardless so that
behaviour remains the same
Diffs
-----
kstyle/breezestyle.cpp 6d18300
Diff: https://git.reviewboard.kde.org/r/122513/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150210/f5e150d5/attachment-0001.html>
More information about the Plasma-devel
mailing list