Review Request 122512: [screenlocker] Add a KKeySequenceWidget to configuration interface

[Martin Gräßlin]

> On Feb. 10, 2015, 4:10 p.m., Bhushan Shah wrote:
> > ksmserver/screenlocker/kcm/kcm.cpp, lines 96-97
> > <https://git.reviewboard.kde.org/r/122512/diff/1/?file=348184#file348184line96>
> >
> >     isn't ksmserver doing this already?

I looked at kwin configuration modules for how it's handled and applied the same pattern. I'm not sure whether this is needed or not.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122512/#review75795
-----------------------------------------------------------


On Feb. 10, 2015, 4:02 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122512/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 4:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 325622
>     https://bugs.kde.org/show_bug.cgi?id=325622
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Allows to configure the global shortcut for locking the screen.
> 
> FEATURE: 325622
> FIXED-IN: 5.3.0
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/kcm/CMakeLists.txt 557e59ad8bf4ece0c6eac4dd98b7dbb985f106cf 
>   ksmserver/screenlocker/kcm/kcm.h 6741e47f81da4d92b9f43587f8372b05949433e4 
>   ksmserver/screenlocker/kcm/kcm.cpp 28f5e35076aedf9c278c11c193895e2535c6c786 
>   ksmserver/screenlocker/kcm/kcm.ui 71d2cb0a9c707d7da178d96cc64dfff4ed7fc9a3 
> 
> Diff: https://git.reviewboard.kde.org/r/122512/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> KCM with new item
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/10/e5030d5e-2662-4458-8bc2-97ed95b43794__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150210/eb9c1808/attachment.html>