Review Request 122511: [screenlocker] Clear password field whenever the visibility changes

[Martin Gräßlin]

> On Feb. 10, 2015, 2:33 p.m., David Edmundson wrote:
> > lookandfeel/contents/lockscreen/LockScreen.qml, line 161
> > <https://git.reviewboard.kde.org/r/122511/diff/1/?file=348176#file348176line161>
> >
> >     Make sure you test this actually gets called when you switch VTs.
> >     
> >     It will require someone to set the window visiblity which has to be done manually.

on manual VT switch (ctrl+alt+f1) this doesn't kick in, but the 30 sec timeout kicks in. Switching via the options provided by the lock screen works, though.

I'm not sure whether we could do anything about the VT switch at all as it causes the GUI to pause.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122511/#review75778
-----------------------------------------------------------


On Feb. 10, 2015, 2:19 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122511/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 2:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 326633
>     https://bugs.kde.org/show_bug.cgi?id=326633
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This ensures that the password field is cleared if the user changes
> to the switch session entry. It's a kind of "protect user from own
> stupidity" change. If the user enters the password, then decides to
> switch user any user would be able to unlock the session.
> 
> [screenlocker] Clear password field after an idle timeout
> 
> Clear the password field if no input happened for 30 sec. This is
> intended for cases that the user starts entering the password and
> then moves away from the system leaving it in a state where anyone
> could unlock the session by just pressing enter.
> 
> BUG: 326633
> FIXED-IN: 5.3.0
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/lockscreen/LockScreen.qml e8997a846dc5ad93e7a1f90c7aa4697ebbc2a67d 
> 
> Diff: https://git.reviewboard.kde.org/r/122511/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150210/db9be9c1/attachment.html>