Review Request 122506: Fix crash due to unsafe access to ShellCorona::m_screenConfiguration

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122506/#review75759
-----------------------------------------------------------



shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/122506/#comment52344>

    I don't know this code at all, but just by looking at it the load() function is only being called via the  setShell() function which sets m_screenConfiguration and then calls load. That seems OK to me.
    
    I only see two possible reasons why m_screenConfiguration could still end up being 0.
    
    1. Some other class calls load() without calling setShell. Put a breakpoint in load to figure out who does that.
    
    2. The "m_screenConfiguration = qobject_cast<KScreen::GetConfigOperation*>(op)->config();" (in the setShell method) somehow fails and returns a null pointer.


- Mark Gaiser


On feb 9, 2015, 11:16 p.m., Sandro Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122506/
> -----------------------------------------------------------
> 
> (Updated feb 9, 2015, 11:16 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Fix crash due to unsafe access to ShellCorona::m_screenConfiguration
> 
> 
> Diffs
> -----
> 
>   shell/shellcorona.cpp cf489b9f8f1abce864bcb3375d3be01bc2c3430d 
> 
> Diff: https://git.reviewboard.kde.org/r/122506/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Mani
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150210/a446abf5/attachment.html>