Review Request 122488: Improved calendar navigation
Sebastian Kügler
sebas at kde.org
Mon Feb 9 14:53:49 UTC 2015
> On Feb. 9, 2015, 3:20 a.m., Aleix Pol Gonzalez wrote:
> > +1 I like it.
> >
> > Why is it even possible to select a day though? It doesn't do anything at the moment...
> >
> > Maybe it would be food that when hovering a day, the weekday was highlighted, it's useful to know what day is it.
>
> Martin Klapetek wrote:
> Can be quite useful as sort of temporary bookmarking (like line highliting in kate). You're doing something on the webs like trip planning, calendar open, you need to remember a date, click, it gets highlighted, then checking other pages you don't need to remember dates or something. And similar. I actually found myself using it quite often (even when planning things with multiple people, that allows me to pin the date I want and creates a viewing anchor for others).
I initially added it assuming we'd get calendaring integration one day. I agree that it's less useful right now, but as long as it doesn't really bother the user, I think it's OK to keep it (or of course make it more useful).
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75656
-----------------------------------------------------------
On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2015, 8:52 p.m.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This improves the calendar navigation by providing a "Year overview" showing all 12 months in a grid, and a "Decade overview" showing the current decade in a grid.
>
> A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness.
>
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!)
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/calendar.cpp a766acb
> src/declarativeimports/calendar/daydata.h 39ac086
> src/declarativeimports/calendar/daysmodel.h ec88837
> src/declarativeimports/calendar/daysmodel.cpp 1a6f454
> src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e
> src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e
> src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db
> src/declarativeimports/calendar/calendar.h ea20bf5
>
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
>
>
> Testing
> -------
>
> I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150209/ef709895/attachment-0001.html>
More information about the Plasma-devel
mailing list