Review Request 122371: Disable session management for kwrited

Vishesh Handa me at vhanda.in
Mon Feb 9 12:12:53 UTC 2015



> On Feb. 8, 2015, 1:49 p.m., David Edmundson wrote:
> > kwrited.cpp, line 74
> > <https://git.reviewboard.kde.org/r/122371/diff/1/?file=346325#file346325line74>
> >
> >     why this?

It's fine. Since kwrited doesn't have any UI, we can safely get away with this. It will reduce loading the current style and decrease memory usage.

We do the same thing in Baloo.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122371/#review75601
-----------------------------------------------------------


On Feb. 1, 2015, 8:55 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122371/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2015, 8:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 343550
>     https://bugs.kde.org/show_bug.cgi?id=343550
> 
> 
> Repository: kwrited
> 
> 
> Description
> -------
> 
> kwrited has its autostart file IMHO doesn't need session management.
> 
> 
> Diffs
> -----
> 
>   kwrited.cpp a4dac6b 
> 
> Diff: https://git.reviewboard.kde.org/r/122371/diff/
> 
> 
> Testing
> -------
> 
> no kwrited started by session.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150209/a1088e64/attachment.html>


More information about the Plasma-devel mailing list