Review Request 122488: Improved calendar navigation

Marco Martin notmart at gmail.com
Mon Feb 9 09:39:45 UTC 2015



> On Feb. 9, 2015, 1:40 a.m., Lukáš Tinkl wrote:
> > src/declarativeimports/calendar/qml/DaysCalendar.qml, line 125
> > <https://git.reviewboard.kde.org/r/122488/diff/1/?file=347953#file347953line125>
> >
> >     I know this is nitpicking but... how is an arrow pointing to the left implemented as previous() meant to work for RTL languages? :)

this was already there, so unrelate,.. it should use the "go-previous" icon tough


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75650
-----------------------------------------------------------


On Feb. 8, 2015, 8:52 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122488/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2015, 8:52 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This improves the calendar navigation by providing a "Year overview" showing all 12 months in a grid, and a "Decade overview" showing the current decade in a grid.
> 
> A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness.
> 
> See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/calendar.cpp a766acb 
>   src/declarativeimports/calendar/daydata.h 39ac086 
>   src/declarativeimports/calendar/daysmodel.h ec88837 
>   src/declarativeimports/calendar/daysmodel.cpp 1a6f454 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
>   src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 
>   src/declarativeimports/calendar/calendar.h ea20bf5 
> 
> Diff: https://git.reviewboard.kde.org/r/122488/diff/
> 
> 
> Testing
> -------
> 
> I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150209/c737e9d0/attachment-0001.html>


More information about the Plasma-devel mailing list