Review Request 122339: Add KWorkSpace::isShuttingDown()

Martin Gräßlin mgraesslin at kde.org
Mon Feb 9 07:38:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122339/#review75659
-----------------------------------------------------------



libkworkspace/kworkspace.cpp
<https://git.reviewboard.kde.org/r/122339/#comment52313>

    why bind to HAVE_X11? If it's not X11 the call will fail and return false.


- Martin Gräßlin


On Jan. 31, 2015, 5:02 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122339/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2015, 5:02 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Bugs: 189456
>     https://bugs.kde.org/show_bug.cgi?id=189456
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Since KSMServer does the session teardown, we can't just rely on Logind's PreparingForShutdown property.
> 
> This patch will allow for instance PowerDevil to not suspend the session when it's currently shutting down, otherwise you'll have your system suspend and continue shutting down after resuming.
> 
> 
> Diffs
> -----
> 
>   ksmserver/shutdown.cpp e6bc708 
>   libkworkspace/kworkspace.h 816f8f1 
>   libkworkspace/kworkspace.cpp ac979bd 
>   ksmserver/org.kde.KSMServerInterface.xml 9dad130 
>   ksmserver/server.h 20b5faa 
> 
> Diff: https://git.reviewboard.kde.org/r/122339/diff/
> 
> 
> Testing
> -------
> 
> Works, adjusted PowerDevil and the system did not suspend during shutdown.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150209/24f56af6/attachment.html>


More information about the Plasma-devel mailing list