Review Request 122400: Add timedated support into the clock KCM as an optional dependency
David Edmundson
david at davidedmundson.co.uk
Sun Feb 8 17:18:47 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122400/
-----------------------------------------------------------
(Updated Feb. 8, 2015, 5:18 p.m.)
Review request for Plasma.
Changes
-------
Changed to runtime detection.
Repository: plasma-desktop
Description
-------
The current time setting helper is incredibly broken.
It manually tries to run a range of NTP utilities, all of which are
deprecated.
We can just call timedated directly and cut out the middleman as it has
uses polkit anyway.
This is currently an optional dependency, and the original helper still
exists. It makes the code messy, but we have users to support for now.
Finding timedated is an cmake option rather than querying for systemd
libs to make it easier for those deploying shims, such as BSD.
(code is in two commits, first abstracting the saving from the dtime class; then adding in the second save mechanism)
Diffs (updated)
-----
kcms/dateandtime/timedated1.xml PRE-CREATION
kcms/dateandtime/main.h c1e5234
kcms/dateandtime/main.cpp 0041a9d
kcms/dateandtime/dtime.h 1a90698
kcms/dateandtime/dtime.cpp 482e483
kcms/dateandtime/CMakeLists.txt 4a987ae
kcms/dateandtime/dateandtime.ui c073b5e
Diff: https://git.reviewboard.kde.org/r/122400/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150208/7f0b1d62/attachment.html>
More information about the Plasma-devel
mailing list