Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

[Martin Klapetek]

> On Feb. 7, 2015, 1 a.m., Kai Uwe Broulik wrote:
> > File Attachment: Lock screen with volume OSD - missing-tasks-applet1.png
> > <https://git.reviewboard.kde.org/r/122452/#fcomment284>
> >
> >     I suggest you add a dialog background framesvg item around it to ease visiblity. Also y should be  2 * (background.height - osd.height) * 3
> >     
> >     This ensures consistency between the real OSD and this one.
> 
> Martin Klapetek wrote:
>     Personally I thought this actually looks better in here than the huge rectangle around. Though maybe it should have at least some rectangle around if not the whole background. Also there are the cases with custom wallpaper which might make this not very clearly seen (well hello blurred desktop background ^_^), sooo...probably should have the whole background, yeah :S

Second thought - this should have the background of the lock strip maybe? The dark one? Maybe?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review75551
-----------------------------------------------------------


On Feb. 6, 2015, 1:03 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 1:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Lock screen with volume OSD
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150207/8de58c35/attachment.html>