Review Request 122451: Whitelist brightness keys in the lockscreen

[Martin Gräßlin]

> On Feb. 6, 2015, 11:21 a.m., Martin Gräßlin wrote:
> > ksmserver/screenlocker/globalaccel.cpp, line 52
> > <https://git.reviewboard.kde.org/r/122451/diff/1/?file=347187#file347187line52>
> >
> >     isn't this missing QList<QString> or is C++11 even smarter than I expected?
> 
> Lukáš Tinkl wrote:
>     It's that smart ;) I was expecting a QStringList instead of QList<QString>, but either is really not necessary with modern compilers.

wohoo, learn something new each day :-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122451/#review75518
-----------------------------------------------------------


On Feb. 6, 2015, 11:04 a.m., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122451/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 11:04 a.m.)
> 
> 
> Review request for Plasma, Daniel Vrátil and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Based on popular request, add brightness keys (increase, decrease) to the lockscreen white list of allowed shortcuts.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/globalaccel.cpp 169515a 
> 
> Diff: https://git.reviewboard.kde.org/r/122451/diff/
> 
> 
> Testing
> -------
> 
> Tested, works fine
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150206/0f757e88/attachment.html>