Review Request 122446: libkscreen needs Qt >= 5.4.0

Rohan Garg rohangarg at kubuntu.org
Thu Feb 5 22:23:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122446/
-----------------------------------------------------------

(Updated Feb. 6, 2015, 3:53 a.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: libkscreen


Description
-------

libkscreen uses QVector::removeAll in backends/xrandr/xrandrcrtc.cpp:82 , which was only introduced in Qt 5.4 and causes compilation to fail on systems with Qt 5.3.

This patch fixes that.


Diffs
-----

  CMakeLists.txt a915140 

Diff: https://git.reviewboard.kde.org/r/122446/diff/


Testing
-------

Compiles fine.


Thanks,

Rohan Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150205/0d3e0078/attachment.html>


More information about the Plasma-devel mailing list