Review Request 122437: [dataengine/mpris2] Add global shortcuts for media control

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122437/
-----------------------------------------------------------

(Updated Feb. 5, 2015, 6:26 p.m.)


Review request for Plasma.


Changes
-------

* changed to Key_MediaPlay - I have that one on three keyboards instead of TogglePlayPause and it's also used by Amarok
* added Key_MediaStop (untested - not on my keyboards)


Repository: plasma-workspace


Description (updated)
-------

The multiplexer registers global shortcuts for:
* play/pause
* next
* previous

and delegates them to the active player if triggered.

This could mean that media shortcuts for non mpris2 enabled
applications might break. The advantage is that we have global
shortcuts for media control.


Diffs (updated)
-----

  dataengines/mpris2/multiplexer.cpp 032f601e283fd25a5a7deea5ce425d7ef4cc0c00 
  dataengines/mpris2/CMakeLists.txt 75b9947f739aa64de633a1ae57b0054d87c092be 

Diff: https://git.reviewboard.kde.org/r/122437/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150205/ecb8322c/attachment.html>