Review Request 122437: [dataengine/mpris2] Add global shortcuts for media control

[Martin Gräßlin]

> On Feb. 5, 2015, 11:04 a.m., Xuetian Weng wrote:
> > Maybe Qt::Key_MediaStop too?
> 
> Marco Martin wrote:
>     would be a good idea to have a global shortcut binded to a single key rather than a combination? (that looks more like a non global shortcut to be used in-app?)

> Maybe Qt::Key_MediaStop too?

I don't have a keyboard with such a key. I can blind add it or you could add after that one is merged.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122437/#review75457
-----------------------------------------------------------


On Feb. 5, 2015, 9:48 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122437/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 9:48 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The multiplexer registers global shortcuts for:
> * play/pause
> * next
> * previous
> 
> and delegates them to the active player if triggered.
> 
> This could mean that media shortcuts for non mpris2 enabled
> applications might break. The advantage is that we have global
> shortcuts for media control.
> 
> 
> Diffs
> -----
> 
>   dataengines/mpris2/CMakeLists.txt 75b9947f739aa64de633a1ae57b0054d87c092be 
>   dataengines/mpris2/multiplexer.cpp 032f601e283fd25a5a7deea5ce425d7ef4cc0c00 
> 
> Diff: https://git.reviewboard.kde.org/r/122437/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150205/f7498556/attachment-0001.html>