Review Request 122437: [dataengine/mpris2] Add global shortcuts for media control

[Martin Gräßlin]

> On Feb. 5, 2015, 11:08 a.m., Martin Klapetek wrote:
> > So what happens when eg. amarok starts and have the same global shortcut registered? Will this popup the "this shortcut is ambiguous" dialog or is that khotkeys only? Or is this first come first served (and so these will always be assigned to plasma because that's started first)?

I have not tried Amarok yet, but my idea here is clearly to take the keys away from applications. I think it is wrong that applications like Amarok take these keys as global shortcuts - application based shortcuts is fine.

>From my understanding of KGlobalAccel it should be "first come, first served".


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122437/#review75458
-----------------------------------------------------------


On Feb. 5, 2015, 9:48 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122437/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 9:48 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The multiplexer registers global shortcuts for:
> * play/pause
> * next
> * previous
> 
> and delegates them to the active player if triggered.
> 
> This could mean that media shortcuts for non mpris2 enabled
> applications might break. The advantage is that we have global
> shortcuts for media control.
> 
> 
> Diffs
> -----
> 
>   dataengines/mpris2/CMakeLists.txt 75b9947f739aa64de633a1ae57b0054d87c092be 
>   dataengines/mpris2/multiplexer.cpp 032f601e283fd25a5a7deea5ce425d7ef4cc0c00 
> 
> Diff: https://git.reviewboard.kde.org/r/122437/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150205/140e5793/attachment.html>