Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122419/
-----------------------------------------------------------

(Updated Feb. 5, 2015, 8:58 a.m.)


Review request for Plasma.


Changes
-------

Dropped the dbus service watcher. Tested, whether kglobalaccel gets started properly if not running.


Bugs: 198097
    https://bugs.kde.org/show_bug.cgi?id=198097


Repository: plasma-workspace


Description
-------

This change implements support for white listed global shortcuts in
the lock screen. It interacts with KGlobalAccel to fetch shortcuts
and checks them when a key is pressed. For more detailed information
on how this functions, please see the documentation added to the new
file globalacel.h.

So far only shortcuts from kmix are white listed. This allows to
mute and change volume while the screen is locked.

CCBUG: 148228
CCBUG: 104353
FEATURE: 198097
FIXED-IN: 5.3.0


Diffs (updated)
-----

  ksmserver/screenlocker/CMakeLists.txt f73ec98bdc05d5cea7802c5ccb1354b6a3efa2f5 
  ksmserver/screenlocker/autotests/CMakeLists.txt 9c940a8fe97ae488aeea53d1f1abb3c38c2e13de 
  ksmserver/screenlocker/globalaccel.h PRE-CREATION 
  ksmserver/screenlocker/globalaccel.cpp PRE-CREATION 
  ksmserver/screenlocker/ksldapp.h 2e2e5dcc721d3854fad4ae4019e767a7d1a33718 
  ksmserver/screenlocker/ksldapp.cpp 8c8607d86d700ade3e1e5b34cbf5c0233897d9ce 
  ksmserver/screenlocker/lockwindow.h cad62ed0f3583f78b0bdb2d96990c8441b8d3b9d 
  ksmserver/screenlocker/lockwindow.cpp 0d5afa879051e0802cf1b676ec6024783d3da959 

Diff: https://git.reviewboard.kde.org/r/122419/diff/


Testing
-------

So far only with the test application


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150205/2f47356e/attachment.html>