Review Request 122420: reimplement some of the systemmonitor plasmoids
David Edmundson
david at davidedmundson.co.uk
Wed Feb 4 14:31:06 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122420/#review75410
-----------------------------------------------------------
Code is all fine.
By default each of these shows nothing; showing everything would be a better default
The disk usage one doesn't seem to work at all. It's not even remembering the options I select
It's auto scaling the graph CPU and memory between the current max and min and not between 0% and 100%.
So if I'm at 1% then have one second at 3% the graph will show it as being full usage which is confusing.
- David Edmundson
On Feb. 4, 2015, 2:10 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122420/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:10 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> this refactors the net systemmonitor plasmoid (hopefully fixing some of the bugs people had with it)
> and brings back some other modules:
> * cpu usage
> * disk i/o activity
> * memory usage
> All applets share most of their stuff having as little duplication as possible
>
>
> Diffs
> -----
>
> applets/systemmonitor/net/metadata.desktop PRE-CREATION
> klipper/org.kde.plasma.clipboard.operations 5e9f71a
> applets/systemmonitor/net/contents/config/config.qml PRE-CREATION
> applets/systemmonitor/net/contents/ui/net.qml PRE-CREATION
> applets/systemmonitor/net/contents/ui/netConfig.qml PRE-CREATION
> applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml PRE-CREATION
> applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml PRE-CREATION
> applets/systemmonitor/diskactivity/metadata.desktop PRE-CREATION
> applets/systemmonitor/diskusage/Messages.sh PRE-CREATION
> applets/systemmonitor/diskusage/contents/config/config.qml PRE-CREATION
> applets/systemmonitor/diskusage/contents/ui/diskusage.qml PRE-CREATION
> applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml PRE-CREATION
> applets/systemmonitor/diskusage/metadata.desktop PRE-CREATION
> applets/systemmonitor/memory/Messages.sh PRE-CREATION
> applets/systemmonitor/memory/contents/config/config.qml PRE-CREATION
> applets/systemmonitor/memory/contents/ui/memory.qml PRE-CREATION
> applets/systemmonitor/memory/contents/ui/memoryConfig.qml PRE-CREATION
> applets/systemmonitor/memory/metadata.desktop PRE-CREATION
> applets/systemmonitor/metadata.desktop 00965ab
> applets/systemmonitor/net/Messages.sh PRE-CREATION
> applets/CMakeLists.txt 25d774e
> applets/systemmonitor/CMakeLists.txt PRE-CREATION
> applets/systemmonitor/Messages.sh 2382ed6
> applets/systemmonitor/common/contents/config/main.xml PRE-CREATION
> applets/systemmonitor/common/contents/ui/Applet.qml PRE-CREATION
> applets/systemmonitor/common/contents/ui/ConfigGeneral.qml PRE-CREATION
> applets/systemmonitor/common/contents/ui/DoublePlotter.qml PRE-CREATION
> applets/systemmonitor/common/contents/ui/SinglePlotter.qml PRE-CREATION
> applets/systemmonitor/contents/config/config.qml 11944e5
> applets/systemmonitor/contents/config/main.xml 57a30cb
> applets/systemmonitor/contents/ui/configGeneral.qml 164e890
> applets/systemmonitor/contents/ui/net.qml 20e1d47
> applets/systemmonitor/cpu/Messages.sh PRE-CREATION
> applets/systemmonitor/cpu/contents/config/config.qml PRE-CREATION
> applets/systemmonitor/cpu/contents/ui/cpu.qml PRE-CREATION
> applets/systemmonitor/cpu/contents/ui/cpuConfig.qml PRE-CREATION
> applets/systemmonitor/cpu/metadata.desktop PRE-CREATION
> applets/systemmonitor/diskactivity/Messages.sh PRE-CREATION
> applets/systemmonitor/diskactivity/contents/config/config.qml PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/122420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150204/8efd20b7/attachment-0001.html>
More information about the Plasma-devel
mailing list