Review Request 122312: Use sysconf() instead of relying on UT_NAMESIZE

Vishesh Handa me at vhanda.in
Wed Feb 4 14:01:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122312/#review75402
-----------------------------------------------------------

Ship it!


Seems sensible.

- Vishesh Handa


On Jan. 29, 2015, 4:53 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122312/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 4:53 p.m.)
> 
> 
> Review request for Plasma and Raphael Kubo da Costa.
> 
> 
> Repository: user-manager
> 
> 
> Description
> -------
> 
> Use sysconf() instead of relying on UT_NAMESIZE
> 
> This will work on any UNIX system even those that don't have utmp.h such
> as FreeBSD.
> 
> 
> Diffs
> -----
> 
>   src/accountinfo.cpp 68fc865 
> 
> Diff: https://git.reviewboard.kde.org/r/122312/diff/
> 
> 
> Testing
> -------
> 
> compiles, runs and shows user name too long tooltip when I enter a really long name
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150204/f3de5fe6/attachment.html>


More information about the Plasma-devel mailing list