Review Request 122411: Prevent notifications from accessing the network

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122411/
-----------------------------------------------------------

(Updated Feb. 4, 2015, 11:01 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

This follows a similar approach as the screenlocker and installs a QQmlNetworkAccessManagerFactory that returns a NetworkAccessManager with accessbility set to no access. This is the most apparent situtation because it accepts arbitrary input but we need a more widespread and unified solution since any applet can basically do anything on file system and network.


Diffs
-----

  applets/notifications/plugin/notificationshelperplugin.h 3c6d45f 
  applets/notifications/plugin/notificationshelperplugin.cpp 1ae8b7f 

Diff: https://git.reviewboard.kde.org/r/122411/diff/


Testing
-------

kdialog --passivepopup "<img src='https://www.kde.org/media/images/kde.png'> Hello"
no longer shows a KDE logo


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150204/990fe009/attachment-0001.html>