Review Request 122318: Sort apps by name if configured

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122318/#review75357
-----------------------------------------------------------



applets/kickoff/core/applicationmodel.h
<https://git.reviewboard.kde.org/r/122318/#comment52122>

    I'd change this to sortAppsByName
    as it doesn't change the actaul data supplied.
    
    We could swap the title/subtitle, but then you have to do that on every model and it gets to a bigger change.


- David Edmundson


On Jan. 29, 2015, 10:02 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122318/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 10:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 343538
>     https://bugs.kde.org/show_bug.cgi?id=343538
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The "show apps by name" option only affected the visual representation, it did not change the actual sorting.
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/core/applicationmodel.h e7399e8 
>   applets/kickoff/core/applicationmodel.cpp 8d2f885 
>   applets/kickoff/package/contents/ui/ApplicationsView.qml 9382882 
> 
> Diff: https://git.reviewboard.kde.org/r/122318/diff/
> 
> 
> Testing
> -------
> 
> Now the items are always sorted alphabetically by whatever is written in the larger font.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150204/6c49ff76/attachment.html>