Review Request 122402: [clipboard] Show barcodes directly in view

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122402/
-----------------------------------------------------------

(Updated Feb. 3, 2015, 1:09 p.m.)


Review request for Plasma and Sune Vuorela.


Changes
-------

adressed Martin's comments - I hope I got the coding style right.


Repository: plasma-workspace


Description
-------

When clicking the barcode button, the view is changed to just show
the barcode instead of opening a dialog. By default a QR Code is
displayed.

A tool button is added which allows to change the barcode type, with
the following barcodes being supported:
* QR
* Data Matrix
* Code 39
* Code 93


Diffs (updated)
-----

  applets/clipboard/contents/ui/clipboard.qml 23cabadd2fec73b2c5343439b821e3d819223eeb 
  klipper/CMakeLists.txt a08f062480b15f32f049e2d0d0e311dbe2964c02 
  klipper/clipboardjob.cpp ad6b6358d0d9bfce25045f997f017e262d6e7f53 
  klipper/org.kde.plasma.clipboard.operations 7f11d536ef2096dd143a9fe376a635222a125a5f 

Diff: https://git.reviewboard.kde.org/r/122402/diff/


Testing
-------


File Attachments
----------------

QR Code
  https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/ba143497-eb97-4389-93ca-752e309386c1__missing-tasks-applet1.png
data Matrix
  https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/5dde29fb-7044-453a-9544-f8f6b9ba5cef__missing-tasks-applet1.png


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150203/bfb36851/attachment.html>