Review Request 122384: Simplify and fix use of IconThemePath in StatusNotifierItems

David Edmundson david at davidedmundson.co.uk
Mon Feb 2 15:48:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122384/
-----------------------------------------------------------

(Updated Feb. 2, 2015, 3:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

Simplify and fix IconThemePath in StatusNotifierItems

KIconLoader gained a second argument in KF5 that allows one to pass an
absolute path to a icons to search.

This saves trying to guess the app name, and adding that. This fixes
certain application icons not loading (for example radiotray)


Diffs
-----

  dataengines/statusnotifieritem/statusnotifieritemsource.cpp 04cbc1a 

Diff: https://git.reviewboard.kde.org/r/122384/diff/


Testing
-------

Ran radiotray on a system with libappindicator. 
Confirmed I got icons correctly


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150202/c86cb9cd/attachment-0001.html>


More information about the Plasma-devel mailing list