Review Request 122065: Fix activity start and stop.
Ivan Čukić
ivan.cukic at kde.org
Sun Feb 1 16:41:22 UTC 2015
> On Jan. 27, 2015, 4:25 p.m., Ivan Čukić wrote:
> > Ship It!
@Xuetian Weng
Do you have commit access, or should I push this?
- Ivan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122065/#review74835
-----------------------------------------------------------
On Jan. 27, 2015, 4:18 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122065/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 4:18 p.m.)
>
>
> Review request for Plasma, Martin Gräßlin and Ivan Čukić.
>
>
> Repository: kactivities
>
>
> Description
> -------
>
> 1. KWin Interface name is wrong
> 2. kactivitymanagerd doesn't listen on ksmserver anymore, thus subSession{Opened,Closed,CloseCanceled} are not called anymore. It need to send Started/Stopped event by itself when kwin dbus call returns.
>
>
> Diffs
> -----
>
> src/service/ksmserver/KSMServer.cpp b5e1467
> src/service/ksmserver/KSMServer_p.h c0f5598
>
> Diff: https://git.reviewboard.kde.org/r/122065/diff/
>
>
> Testing
> -------
>
> Now starting and stopping activity works properly.
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150201/a9654521/attachment.html>
More information about the Plasma-devel
mailing list