Review Request 122246: Add addSample(qreal value) overload

Kai Uwe Broulik kde at privat.broulik.de
Sun Feb 1 11:51:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122246/
-----------------------------------------------------------

(Updated Feb. 1, 2015, 11:51 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: kdeclarative


Description
-------

Add an addSample(qreal value) overload making it easier to work with just a simple dataset. This way you can do plotter.addSample(50) instead of plotter.addSample([50]).

QML seems to accept single strings for QStringList but not other list types.


Diffs
-----

  src/qmlcontrols/kquickcontrolsaddons/plotter.h 3a10212 
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 65dee7a 

Diff: https://git.reviewboard.kde.org/r/122246/diff/


Testing
-------

addSample(50) and addSample([40, 41, 42]) work


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150201/014e37b1/attachment.html>


More information about the Plasma-devel mailing list