Review Request 124047: Improve clock's tooltip layout

[Martin Klapetek]

> On Dec. 31, 2015, 9:47 p.m., Kai Uwe Broulik wrote:
> > you're now sorting in two separate places. can't you have one function in qml and sort in both component completed and in on selected timezones changed?

No; sorting the array in onSelectingTimeZonesChanged (and setting it to plasmoid.configuration.selectedTimeZones) triggers the Changed signal and it makes inifinite recursive call.

Plus, the first place is the applet and the second place is the configuration interface model, which are different places...technically anyway.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/#review90384
-----------------------------------------------------------


On Dec. 31, 2015, 9:40 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124047/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2015, 9:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348078
>     https://bugs.kde.org/show_bug.cgi?id=348078
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> In kde4 times, the layout of clock's tooltip was nicely arranged using a table. Now it's a bit of a mess so this brings back the table.
> 
> Also simplifies the timeForZone function which is used only for the tooltip.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9 
>   applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e754925 
>   applets/digital-clock/plugin/timezonedata.h 682b7c7 
>   applets/digital-clock/plugin/timezonemodel.h 39f64f4 
>   applets/digital-clock/plugin/timezonemodel.cpp 2fe7b16 
> 
> Diff: https://git.reviewboard.kde.org/r/124047/diff/
> 
> 
> Testing
> -------
> 
> See screenshots.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151231/4607d1a2/attachment.html>