Review Request 126578: [Kickoff/Kicker] Add context menu actions for search results

[Thomas Pfeiffer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126578/#review90361
-----------------------------------------------------------


Looks great, no objections!

- Thomas Pfeiffer


On Dec. 30, 2015, 7:09 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126578/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, 7:09 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This adds the context menu actions you also get in the favorites and applications view to search results.
> 
> Usability: This enables this for Kickoff, Kicker and Application Dashboard.
> 
> I did not add the "Edit application" context menu as search results are somewhat conceptually detached from the application menu structure.
> 
> 
> Diffs
> -----
> 
>   applets/kicker/package/contents/ui/main.qml 5defa75 
>   applets/kicker/plugin/actionlist.h 58dd6dd 
>   applets/kicker/plugin/actionlist.cpp 6d73434 
>   applets/kicker/plugin/appentry.cpp 61fd8a9 
>   applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 
>   applets/kicker/plugin/runnermodel.h 4c3f212 
>   applets/kicker/plugin/runnermodel.cpp 6496816 
>   applets/kickoff/package/contents/ui/Kickoff.qml 8a8c9c5 
> 
> Diff: https://git.reviewboard.kde.org/r/126578/diff/
> 
> 
> Testing
> -------
> 
> Steam favorite: Add to desktop, panel, task manager work, "Screenshots" jump list action works
> 
> Searched for "steam": Add to desktop, panel, task manager work, "Screenshots" jump list action works
> 
> 
> File Attachments
> ----------------
> 
> Search result menu
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/30/2e00c239-3dcc-4253-9c0c-0563a11de9b2__steaminsearch.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151230/ecd99b76/attachment.html>