Review Request 126576: Don't emit signals in another object from panel.
David Edmundson
david at davidedmundson.co.uk
Wed Dec 30 12:00:42 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126576/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
Emitting objects in another object is generally bad practice.
ShellCorona::availableScreenRect knows what properties of panelview we
use, so tracking of property changes should be in ShellCorona.
Diffs
-----
shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7
shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd
Diff: https://git.reviewboard.kde.org/r/126576/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151230/6eaf5b28/attachment.html>
More information about the Plasma-devel
mailing list