Review Request 126562: Deal properly with symlinks in path to packages

[Kevin Ottens]

> On Dec. 29, 2015, 3:22 p.m., David Edmundson wrote:
> > src/plasmaquick/packageurlinterceptor.cpp, line 93
> > <https://git.reviewboard.kde.org/r/126562/diff/1/?file=427737#file427737line93>
> >
> >     why the +1?
> >     
> >     is it that canonicalFilePath not leave a trailing slash which we had before?

Yep, that's the reason, it strips the trailing slash.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126562/#review90291
-----------------------------------------------------------


On Dec. 29, 2015, 3:08 p.m., Kevin Ottens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126562/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 3:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> We receive the URL with all symlinks resolved, but internally the
> pkgRoot kept unresolved symlinks preventing matches if there was a
> symlink somewhere to get to the package.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/packageurlinterceptor.cpp 5bd600c 
> 
> Diff: https://git.reviewboard.kde.org/r/126562/diff/
> 
> 
> Testing
> -------
> 
> All applets work for me without the older patches I had:
> https://git.reviewboard.kde.org/r/124204/
> https://git.reviewboard.kde.org/r/124205/
> https://git.reviewboard.kde.org/r/124206/
> https://git.reviewboard.kde.org/r/124207/
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151229/923ffbe1/attachment-0001.html>