Review Request 126557: use the new KDEPackageAppTemplates ECM module

Marco Martin notmart at gmail.com
Tue Dec 29 14:45:26 UTC 2015



> On Dec. 29, 2015, 2:37 p.m., David Edmundson wrote:
> > CMakeLists.txt, line 7
> > <https://git.reviewboard.kde.org/r/126557/diff/1/?file=427707#file427707line7>
> >
> >     is this still right?
> 
> Marco Martin wrote:
>     hmm, nope, updating to 18

aww, shit, mixed up the commit with unrelated stuff, sorry :/


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126557/#review90286
-----------------------------------------------------------


On Dec. 29, 2015, 2:42 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126557/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 2:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> drop local copy of the module
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a27b3ac 
>   cmake/KDETemplateMacro.cmake 796c3f1 
>   templates/CMakeLists.txt 773c471 
> 
> Diff: https://git.reviewboard.kde.org/r/126557/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151229/e30d85e1/attachment.html>


More information about the Plasma-devel mailing list