Review Request 126559: dark colorscheme option for cuttlefish

David Edmundson david at davidedmundson.co.uk
Tue Dec 29 14:35:18 UTC 2015



> On Dec. 29, 2015, 2:32 p.m., David Edmundson wrote:
> > cuttlefish/package/contents/ui/Tools.qml, line 130
> > <https://git.reviewboard.kde.org/r/126559/diff/1/?file=427731#file427731line130>
> >
> >     may be better to make the text be more like: ComplementaryColorGroup
> >     
> >     
> >     otherwise if you're editing a dark theme it's confusing.
> 
> Marco Martin wrote:
>     inverted color scheme?

+1


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126559/#review90283
-----------------------------------------------------------


On Dec. 29, 2015, 1:35 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126559/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 1:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> -------
> 
> Since now icons from the system theme are supposed to have the full stylesheet data in order to be colorized, add a dark colorscheme option in cuttlefish for a quick glance at what icons have a correct stylesheet and what don't
> 
> 
> Diffs
> -----
> 
>   cuttlefish/package/contents/ui/IconGridDelegate.qml 0a36b68 
>   cuttlefish/package/contents/ui/Preview.qml acdb2be 
>   cuttlefish/package/contents/ui/Tools.qml c496f55 
>   cuttlefish/package/contents/ui/cuttlefish.qml 8bfe345 
> 
> Diff: https://git.reviewboard.kde.org/r/126559/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> cuttlefish.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4d705ca8-7aa0-4312-8901-0636502796f4__cuttlefish.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151229/c43c181d/attachment-0001.html>


More information about the Plasma-devel mailing list