Review Request 126548: Kill PowerDevil runner
Xuetian Weng
wengxt at gmail.com
Mon Dec 28 17:46:33 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126548/#review90239
-----------------------------------------------------------
I can see that it provides suspend, sleep, hibernate feature which is still useful (Though for some reason I can't trigger it here). Maybe merge that part into sessions runner and drop others?
- Xuetian Weng
On Dec. 28, 2015, 5:22 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126548/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 5:22 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> * I have no idea how to use it
> * I have never used it
> * It allows switching profiles which were removed half a decade ago
> * Its brightness handling is most likely broken
> * There's global keyboard shorcuts and battery monitor
> * I'm not willing to maintain it and/or ensure it keeps working
>
>
> Diffs
> -----
>
> runners/CMakeLists.txt 48cc379
> runners/powerdevil/CMakeLists.txt 7c03e29
> runners/powerdevil/Messages.sh 99ae5dc
> runners/powerdevil/PowerDevilRunner.h 7995621
> runners/powerdevil/PowerDevilRunner.cpp 527a2c2
> runners/powerdevil/plasma-runner-powerdevil.desktop 647f66e
>
> Diff: https://git.reviewboard.kde.org/r/126548/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151228/511169f4/attachment-0001.html>
More information about the Plasma-devel
mailing list