Review Request 126524: Fixed custom wallpaper being not respected by sddm.

Joshua Noack joshua.noack at gmail.com
Mon Dec 28 15:43:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126524/
-----------------------------------------------------------

(Updated Dec. 28, 2015, 3:43 p.m.)


Review request for Plasma and David Edmundson.


Bugs: 355918
    https://bugs.kde.org/show_bug.cgi?id=355918


Repository: sddm-kcm


Description
-------

For some reason sddm cannot handle absolute file paths to wallpapers
and also needs the wallpaper to be readable by others.

This is fixed by copying the wallpaper to the root directory of the
selected theme.

On save the sddmauthhelper copies the background from the absolute path
into the theme directory and sets the "background" key of the
theme.user.conf to the copied file. If previously a different background was
set it is removed beforehand.


Diffs
-----

  sddmauthhelper.cpp 648b24c77e7570641d454fca9d121709a622bc36 
  src/themeconfig.cpp bdd6dd29fd8eb052e2f2b2239b0c46ebbebec88c 

Diff: https://git.reviewboard.kde.org/r/126524/diff/


Testing
-------

Copies and removes backgrounds as intended.
The wallpaper is shown in sddm.


Thanks,

Joshua Noack

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151228/9484a370/attachment.html>


More information about the Plasma-devel mailing list