Review Request 126514: [Milou/KRunner] Support runner actions

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126514/#review90212
-----------------------------------------------------------


hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand QIcons as it uses IconItem internally

- Marco Martin


On Dec. 28, 2015, 12:33 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126514/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 12:33 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Vishesh Handa.
> 
> 
> Repository: milou
> 
> 
> Description
> -------
> 
> This brings back support for additional runner actions. A runner can specify supplemental actions to a search result.
> 
> It is deliberately no ToolButton as that would look weird, the Highlight blends in much better, although I'm not too happy with the huge Plasma tooltip. I'm not sure how keyboard interaction should work as both Tab and arrow keys would conflict with navigation.
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt 1123b60 
>   lib/qml/ResultDelegate.qml 6d60bf2 
>   lib/qml/ResultsView.qml b36cc19 
>   lib/sourcesmodel.h 6c2d205 
>   lib/sourcesmodel.cpp 65c69b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126514/diff/
> 
> 
> Testing
> -------
> 
> Hardly any runner makes use of this, though.
> I got the kill runner to send sigterm and sigkill, and also some mysterious ktp runer I couldn't find where it is offers "Start Chat" and "Open Chat Log" actions. The Solid runner supposedly also adds actions but I couldn't get that to work.
> 
> Unfortunately I had to add QtWidgets for QAction :(
> 
> 
> File Attachments
> ----------------
> 
> Runner action
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/25/3b70cc42-f3f9-42e5-aa5c-3b30067ae06e__krunneractions.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151228/30132201/attachment.html>