Review Request 126544: [Kickoff] Hide history tab if empty

Kai Uwe Broulik kde at privat.broulik.de
Mon Dec 28 13:58:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126544/
-----------------------------------------------------------

Review request for Plasma, KDE Usability and Eike Hein.


Repository: plasma-desktop


Description
-------

This hides the "History" tab if it is empty.

This can permanently happen if you use disable tracking in activity settings or administrative means.


Diffs
-----

  applets/kickoff/package/contents/ui/FavoritesView.qml 5b7a2cf 
  applets/kickoff/package/contents/ui/FullRepresentation.qml c2f5ad8 
  applets/kickoff/package/contents/ui/RecentlyUsedView.qml 7169622 

Diff: https://git.reviewboard.kde.org/r/126544/diff/


Testing
-------

Button comes and goes as I add and remove history entries.

When I clear the history, it switches to the Favorites view so you don't end up with a broken view.

It doesn't seem to track application launches through Kickoff but I think this is unrelated.


File Attachments
----------------

No history tab
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/3f2f0697-b5ce-420a-bfc9-8e949b345439__hiddenhistory.jpg


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151228/00a8036f/attachment.html>


More information about the Plasma-devel mailing list