Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

Marco Martin notmart at gmail.com
Mon Dec 28 09:31:54 UTC 2015



> On Dec. 27, 2015, 4:54 p.m., Kai Uwe Broulik wrote:
> > desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml, line 106
> > <https://git.reviewboard.kde.org/r/126499/diff/1/?file=425591#file425591line106>
> >
> >     You didn't specify a width, ie. there'll be no wrapping

yeah, there should be no Row, the label should have left/right anchors and wrapping explicitly enabled


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126499/#review90157
-----------------------------------------------------------


On Dec. 24, 2015, 1:43 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126499/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2015, 1:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> BUG: 356874
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml 9d04d0aa8b53f219e937228f91abee5ff439d02a 
> 
> Diff: https://git.reviewboard.kde.org/r/126499/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151228/33c4ec50/attachment.html>


More information about the Plasma-devel mailing list