Review Request 126491: Set root context properties on the right context

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126491/
-----------------------------------------------------------

(Updated Dec. 27, 2015, 10:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit c692bc53a8c5cf5802084085b9aed11203998d38 by David Edmundson to branch Plasma/5.5.


Bugs: 355885, 356545 and 356916
    https://bugs.kde.org/show_bug.cgi?id=355885
    https://bugs.kde.org/show_bug.cgi?id=356545
    https://bugs.kde.org/show_bug.cgi?id=356916


Repository: plasma-workspace


Description
-------

engine()->rootContext() will give a different result to
rootContext() when using a shared engine.

One being in the right context, the other being the context of the
shared engine. Using the latter means two panels end up sharing the same
object which leads to some interesting results and QML crashes in
QV4::QObjectWrapper::wrap when one gets deleted.

I've tested against 356545, but I think it's the cause of a lot of the
mystery QML bugs we couldn't figure out.

BUG: 356545
BUG: 355885
BUG: 356916


Diffs
-----

  shell/containmentconfigview.cpp bf2b9287acb8188d63068b5389b3d55bfbdbf76b 
  shell/panelconfigview.cpp 29a50bc03d8750e2370c5c2b5cfe761a031c43e9 
  shell/panelview.cpp 893def0ced7297271d03dd27f40f8f6599a2354f 
  shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd 

Diff: https://git.reviewboard.kde.org/r/126491/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151227/b8f1830e/attachment.html>