Review Request 126538: Don't duplicate a tonne of KCrash code

David Edmundson david at davidedmundson.co.uk
Sun Dec 27 21:10:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126538/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-workspace


Description
-------

KCrash already has auto restart which copies the args and only respawns
n times, resetting if we last longer than m seconds.

Timeouts are sligthly different, but if changes are genuinely needed we can add options to KCrash.


Diffs
-----

  shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 
  shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 
  shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 

Diff: https://git.reviewboard.kde.org/r/126538/diff/


Testing
-------

None.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151227/79e05b4f/attachment.html>


More information about the Plasma-devel mailing list