Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi

[Kai Uwe Broulik]

> On Dez. 25, 2015, 5:22 nachm., David Edmundson wrote:
> > On first thought this is awesome. I like the video. It looks good.
> > 
> > but now I'm going to point something out that's going to ruin your Christmas
> > 
> > If Plasma crashes, you're going to try and show an SNI *in plasma* ... which isn't running.
> > That's fine for a single crash, not for ones that block startup.
> > 
> > I'm sure we can workaround this somehow - there's a timer in KCrash internals where we can know if something is a crash within the first 20 seconds of loading.
> 
> Kai Uwe Broulik wrote:
>     That's why on third (and last) restart attempt it'll bring up DrKonqi nonetheless. Good point nonetheless.
> 
> David Edmundson wrote:
>     so it does.
>     
>     +1

There: https://www.youtube.com/watch?v=mIoMaJ7e8s4 :)

Just instead of that KPassivePopup (I already played around with my other usability idea) with this patch you would get regular DrKonqi.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126517/#review90102
-----------------------------------------------------------


On Dez. 25, 2015, 4:24 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126517/
> -----------------------------------------------------------
> 
> (Updated Dez. 25, 2015, 4:24 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This enables the StatusNotifier option introduced in Review 126516, see Review 126515 for more information.
> 
> When Plasma reached the recursion counter it disables the passive option since there will most likely be no System Tray to show this error and then something's really wrong in the first place.
> 
> 
> Diffs
> -----
> 
>   shell/shellmanager.cpp 0a6ac5e 
> 
> Diff: https://git.reviewboard.kde.org/r/126517/diff/
> 
> 
> Testing
> -------
> 
> Crashed plasma two times, it restarted and I got two SNIs, crashed it another time, got black screen with DrKonqi dialog.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151225/91d58c1e/attachment-0001.html>