Review Request 126438: Fix bug 356946 - user avatar in Phonon isn't shrinked

Artur Puzio cytadela88 at gmail.com
Wed Dec 23 21:52:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126438/
-----------------------------------------------------------

(Updated Dec. 23, 2015, 9:52 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 7a7f171cdd677c433b7c0966550badbfeb3d6b1e by David Edmundson on behalf of Artur Puzio to branch Plasma/5.5.


Bugs: 356946
    https://bugs.kde.org/show_bug.cgi?id=356946


Repository: plasma-desktop


Description
-------

As discribed in the bug report: when users has a avatar it's shown in sound kcm in "Speaker Placement and Testing", but it's not resized. (e.g. If it is a 1000x1000 image it takes 1000x1000px on screen.) This simple patch forces maximum size of `KIconLoader::SizeHuge` what is the same as default icon size.
Aspect ratio isn't preserved, but please note that in many other places it's also assumed that avatar is a square.


Diffs
-----

  kcms/phonon/audiosetup.cpp 4bdba69 

Diff: https://git.reviewboard.kde.org/r/126438/diff/


Testing
-------

Installed patched version. Checked visually sound kcm on account with avatar and on account without an avatar.


Thanks,

Artur Puzio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151223/6d1b3d51/attachment.html>


More information about the Plasma-devel mailing list