Review Request 126438: Fix bug 356946 - user avatar in Phonon isn't shrinked

[Artur Puzio]

> On Gru 21, 2015, 11:46 rano, Sebastian Kügler wrote:
> > Could you attach before/after screenshots, please?

[before without avatar](http://i.imgur.com/lpkcf3A.png)
[before with avatar](http://i.imgur.com/E8Zu8kv.jpg)
[after with avatar](http://i.imgur.com/BkkJvGR.png)
[after without avatar](http://i.imgur.com/DBGpRKK.png)
*avatar used for testing is a random very old screenshot*


- Artur


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126438/#review89812
-----------------------------------------------------------


On Gru 20, 2015, 10:12 po południu, Artur Puzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126438/
> -----------------------------------------------------------
> 
> (Updated Gru 20, 2015, 10:12 po południu)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 356946
>     https://bugs.kde.org/show_bug.cgi?id=356946
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> As discribed in the bug report: when users has a avatar it's shown in sound kcm in "Speaker Placement and Testing", but it's not resized. (e.g. If it is a 1000x1000 image it takes 1000x1000px on screen.) This simple patch forces maximum size of `KIconLoader::SizeHuge` what is the same as default icon size.
> Aspect ratio isn't preserved, but please note that in many other places it's also assumed that avatar is a square.
> 
> 
> Diffs
> -----
> 
>   kcms/phonon/audiosetup.cpp 4bdba69 
> 
> Diff: https://git.reviewboard.kde.org/r/126438/diff/
> 
> 
> Testing
> -------
> 
> Installed patched version. Checked visually sound kcm on account with avatar and on account without an avatar.
> 
> 
> Thanks,
> 
> Artur Puzio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151223/92f62f6a/attachment.html>