Review Request 124047: Improve clock's tooltip layout

Tue Dec 22 21:53:59 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/#review89950
-----------------------------------------------------------

It still does not shrink if timezones are removed.

Otherwise looking good.

applets/digital-clock/package/contents/ui/DigitalClock.qml (lines 584 - 590)
<https://git.reviewboard.kde.org/r/124047/#comment61658>

    You should probably sort them also when I add new ones in the config UI.

- Kai Uwe Broulik

On Dez. 22, 2015, 7:38 nachm., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124047/
> -----------------------------------------------------------
> 
> (Updated Dez. 22, 2015, 7:38 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 348078
>     https://bugs.kde.org/show_bug.cgi?id=348078
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> In kde4 times, the layout of clock's tooltip was nicely arranged using a table. Now it's a bit of a mess so this brings back the table.
> 
> Also simplifies the timeForZone function which is used only for the tooltip.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9 
>   applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION 
>   applets/digital-clock/package/contents/ui/main.qml e754925 
> 
> Diff: https://git.reviewboard.kde.org/r/124047/diff/
> 
> 
> Testing
> -------
> 
> See screenshots.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151222/84d8ae50/attachment.html>