Review Request 124047: Improve clock's tooltip layout

Martin Klapetek martin.klapetek at gmail.com
Tue Dec 22 19:34:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 8:34 p.m.)


Review request for Plasma.


Changes
-------

Rebased on master; with the toolTipItem changes there's no more
sliding of the tooltip from aside. Also if only one zone is selected
(default) it's not displayed in the tooltip. Also it now shows a date
if the timezone already has a different day (follows date format setting)

See updated screenshot for current look.


Bugs: 348078
    https://bugs.kde.org/show_bug.cgi?id=348078


Repository: plasma-workspace


Description
-------

In kde4 times, the layout of clock's tooltip was nicely arranged using a table. Now it's a bit of a mess so this brings back the table.

Also simplifies the timeForZone function which is used only for the tooltip.


Diffs (updated)
-----

  applets/digital-clock/package/contents/ui/DigitalClock.qml 56e31b9 
  applets/digital-clock/package/contents/ui/main.qml e754925 

Diff: https://git.reviewboard.kde.org/r/124047/diff/


Testing
-------

See screenshots.


File Attachments (updated)
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/22/b51c1559-8f2c-42bc-8eb6-203ef3d53637__snapshot69.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151222/44c88a11/attachment-0001.html>


More information about the Plasma-devel mailing list