Review Request 126475: Make sure PlasmaCore.WindowThumbnail doesn't redirect windows while disabled or invisible

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126475/#review89947
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Dec. 22, 2015, 6:18 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126475/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 6:18 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Gräßlin.
> 
> 
> Bugs: 356938
>     http://bugs.kde.org/show_bug.cgi?id=356938
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> PlasmaCore.WindowThumbnail acts as a mini-compositor and redirects windows to paint a thumbnail of them. Hovering a Task Manager button delegate will down the line instanciate some WindowThumbnails for the tooltip, and these stick around when the tooltip is hidden. This causes windows to keep being redirected, e.g. severely breaking game performance after hovering them in the Task Manager (see associated bug).
> 
> I initially tried just wiping the thumbnail delegates on the Task Manager side when the tooltip goes hidden, but this breaks UX performance when moving across tasks in the applet because the tooltip delegate's visibility prop cycles between true and false from one ToolTipArea to the next. I'll still be tweaking the Task Manager code to at the very least do this when tooltips are disabled to avoid even instanciating, but in the meantime, making WindowThumbnail more idiot-proof strikes me as a good idea regardless.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/windowthumbnail.cpp 5fc5c5e 
> 
> Diff: https://git.reviewboard.kde.org/r/126475/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151222/bddc3a5c/attachment.html>