Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 4:32 p.m.)


Review request for Plasma and David Edmundson.


Changes
-------

v2 adopts David's suggestion. In addition to dropping the timer, things now call schedulePixmapUpdate() instead of loadPixmap(), which schedules a call to loadPixmap() in updatePaintNode(). loadPixmap() no longer calls update(), which is a nice cleanliness bonus.


Bugs: 345545
    http://bugs.kde.org/show_bug.cgi?id=345545


Repository: plasma-framework


Description
-------

This timer seems to exist purely to delay loading the pixmap for the purpose of "hey, maybe it will work later ..." when it's not actually needed thanks to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and fixes various icon flicker around Plasma, in particular in the Task Manager: When swapping out a launcher delegate for a task delegate, or when swapping out delegates during virtual desktop switches.


Diffs (updated)
-----

  src/declarativeimports/core/iconitem.h 3abef40 
  src/declarativeimports/core/iconitem.cpp bada940 

Diff: https://git.reviewboard.kde.org/r/126466/diff/


Testing
-------


Thanks,

Eike Hein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151222/4912b55e/attachment.html>