Review Request 126468: AppletQuickItem: Drop timer to create full representation

David Rosca nowrep at gmail.com
Tue Dec 22 14:58:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126468/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 2:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 344dbeb93884af36f66e9a5133e7be7bd1b1e70d by David Rosca to branch master.


Repository: plasma-framework


Description
-------

The timer only added 250ms delay before creating the full representation, sometimes resulting in showing empty popup for a moment.


Diffs
-----

  src/plasmaquick/appletquickitem.h dffbcf3 
  src/plasmaquick/appletquickitem.cpp 5f6b857 
  src/plasmaquick/private/appletquickitem_p.h 5a7f9db 

Diff: https://git.reviewboard.kde.org/r/126468/diff/


Testing
-------

Works fine. Sometimes the very first popup is still a little buggy, but it is much better than before and also the bug doesn't come back again during the plasmashell lifetime.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151222/9be2d39c/attachment-0001.html>


More information about the Plasma-devel mailing list