Review Request 126472: Don't always load the timetracker

Aleix Pol Gonzalez aleixpol at kde.org
Tue Dec 22 14:21:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126472/#review89921
-----------------------------------------------------------


I'm ok with this, although it wasn't guarded initially because it was asked not to. IIRC.

Anyway, +1.

- Aleix Pol Gonzalez


On Dec. 22, 2015, 3:14 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126472/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 3:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Don't always load the timetracker
> 
> It has a timer that wakes up every 2 seconds and drains my battery just
> simply because I have debug builds. This make it on demand.
> 
> Don't track containments twice.
> Containments inherit from Applets which also have the same line
> 
> 
> Diffs
> -----
> 
>   src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 
>   src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f 
>   src/plasma/private/containment_p.cpp 86d27c43f36b9e1741ab13f8153080fb6b92b321 
> 
> Diff: https://git.reviewboard.kde.org/r/126472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151222/157e7460/attachment-0001.html>


More information about the Plasma-devel mailing list