Review Request 126468: AppletQuickItem: Drop timer to create full representation

[David Rosca]

> On Dec. 22, 2015, 12:03 p.m., David Edmundson wrote:
> > you talk about popups, but have you tested applets on the desktop?
> > 
> > Definitely this is a change we want to be making, but it looks like a workaround for something else being terribly broken, we need to be sure that's fixed.
> > 
> > I'll apply this too and also check.

Yes, I did test applets on desktop and switching from compact to full representation works as before.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126468/#review89902
-----------------------------------------------------------


On Dec. 22, 2015, 10:01 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126468/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 10:01 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> The timer only added 250ms delay before creating the full representation, sometimes resulting in showing empty popup for a moment.
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/appletquickitem.h dffbcf3 
>   src/plasmaquick/appletquickitem.cpp 5f6b857 
>   src/plasmaquick/private/appletquickitem_p.h 5a7f9db 
> 
> Diff: https://git.reviewboard.kde.org/r/126468/diff/
> 
> 
> Testing
> -------
> 
> Works fine. Sometimes the very first popup is still a little buggy, but it is much better than before and also the bug doesn't come back again during the plasmashell lifetime.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151222/5cf95516/attachment.html>