Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

Eike Hein hein at kde.org
Tue Dec 22 03:17:03 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/
-----------------------------------------------------------

Review request for Plasma and David Edmundson.


Bugs: 345545
    http://bugs.kde.org/show_bug.cgi?id=345545


Repository: plasma-framework


Description
-------

This timer seems to exist purely to delay loading the pixmap for the purpose of "hey, maybe it will work later ..." when it's not actually needed thanks to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and fixes various icon flicker around Plasma, in particular in the Task Manager: When swapping out a launcher delegate for a task delegate, or when swapping out delegates during virtual desktop switches.


Diffs
-----

  src/declarativeimports/core/iconitem.cpp e260487 

Diff: https://git.reviewboard.kde.org/r/126466/diff/


Testing
-------


Thanks,

Eike Hein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151222/1d759512/attachment.html>


More information about the Plasma-devel mailing list