Review Request 126463: Allow applets to set full ToolTip item

[Kai Uwe Broulik]

> On Dez. 21, 2015, 10:39 nachm., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.h, line 407
> > <https://git.reviewboard.kde.org/r/126463/diff/1/?file=425189#file425189line407>
> >
> >     what would happen if the tooltipItem object gets deleted by the plasmoid after having set the object in the applet interface?

"deleted by the plasmoid" means deleted from QML means the QML engine will set the property to null, if I'm not mistaken?


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/#review89868
-----------------------------------------------------------


On Dez. 21, 2015, 10:12 nachm., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126463/
> -----------------------------------------------------------
> 
> (Updated Dez. 21, 2015, 10:12 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Adds new property available as Plasmoid.toolTipItem that allows
> to set a full custom item as the tooltip.
> 
> The main motivation is to have a custom Item tooltip for digital
> clock to properly format the list of timezones (version of
> https://git.reviewboard.kde.org/r/124047/). Adding a custom
> PlasmaCore.ToolTipArea to the compact representation does not
> work well because then it's a ToolTipArea nested inside another
> ToolTipArea (from CompactApplet.qml), this causes a sliding effect
> as it changes visual parents when hovering.
> 
> I dunno if this could perhaps be fixed, but seems redundant to have
> two ToolTipAreas anyway, so instead this exposes the main applet's
> ToolTipArea's mainItem property through Plasmoid.toolTipItem which
> the appelts can use to set a custom item.
> 
> This has a part2 patch which goes of plasma-desktop:
> https://git.reviewboard.kde.org/r/126464/
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126463/diff/
> 
> 
> Testing
> -------
> 
> I can have custom tooltip item in digital clock without any artifacts
> while all other applets still have correct tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151221/4ff7154e/attachment-0001.html>