Review Request 126449: Containment: Don't emit appletCreated with null applet

[Kai Uwe Broulik]

> On Dez. 21, 2015, 1:54 nachm., David Edmundson wrote:
> > Thanks!
> > 
> > This will fix https://bugs.kde.org/show_bug.cgi?id=356428 right?
> 
> David Rosca wrote:
>     It should, according to the backtrace.
> 
> David Edmundson wrote:
>     at which point can you cherry-pick it to the 5.5 branch too please? and close that bug report.
> 
> David Rosca wrote:
>     This is plasma-framework. But it can also be fixed in plasma-workspace with checking the desktp immutability before adding the applet, if it's worth it?

executeSetupPlasmoidScript should perhaps check for plugininfo validity


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126449/#review89825
-----------------------------------------------------------


On Dez. 21, 2015, 2:01 nachm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126449/
> -----------------------------------------------------------
> 
> (Updated Dez. 21, 2015, 2:01 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> ContainmentPrivate::createApplet may return null pointer (eg. when desktop is immutable), so check the pointer before emitting appletCreated.
> 
> 
> Diffs
> -----
> 
>   src/plasma/containment.cpp 512cdc4 
> 
> Diff: https://git.reviewboard.kde.org/r/126449/diff/
> 
> 
> Testing
> -------
> 
> Fixes crash when pasting to desktop with locked widgets.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151221/df463458/attachment.html>